Tobias Tengler
Tobias Tengler
@captbaritone Also fixed the conflicts here. Ready to be merged again :)
Oh yeah 😅 I forgot about it over the holidays, since it didn't impact me. Will try to finish this tomorrow!
I would say it catches 40% of the race conditions between `textdocument/didchange` and `textdocument/completion`. I validated this in my testing by checking the occurence of the debug statement I added....
It seems like all the issues were being caused by the TaskQueue essentially fire-and-forgetting the processing of tasks. I opted to execute all the notification tasks concerning the document content,...
Have been using a local build of the LSP (from this PR) in our project for two days now and can verify that I haven't had a wrong completion since...
While this already works really reliably, I'd like to extend the solution with something a little bit more sophisticated to also wait for ongoing `textdocument/*` requests to finish, before processing...
@captbaritone @alunyov this would be ready to review :) I've also made a quick recording to showcase what exactly this solves (it might also be the source of other subtle...
This issue should be high priority IMO. All it takes is for a developer to include `serviceWorker.register();`, deploying that version, people visiting that version of the site, pushing a new...
Is this still blocked internally?
@captbaritone Added object type suggestions and a feature flag to disable the validation :)