codespeed icon indicating copy to clipboard operation
codespeed copied to clipboard

ChangeSet URL setting to link revisions on /changes/ page

Open techtonik opened this issue 14 years ago • 4 comments
trafficstars

On http://speed.pypy.org/changes/ revisions are not linked to specific revisions. I guess that's because codespeed doesn't have a setting or can not link Mercurial revisions.

techtonik avatar Jun 22 '11 11:06 techtonik

You mean a direct link to the Bitbucket changeset page?

To do that, Codespeed would need to now the Bitbucket URL convention, which means that a Bitbucket plugin (instead of the current plain mercurial) would need to be implemented.

Bitbucket's URL for chancheset links is of the form https://bitbucket.org/<project_url>/changeset/<commit_id>

tobami avatar Jun 22 '11 18:06 tobami

Does it really need a plugin? I believe that simple setting for browser URL, where revision is just appended to it can cover 95% of VCS browsers out there. With support for expansion variables like $commit_id in this URL, a full coverage can be reached.

techtonik avatar Jun 23 '11 16:06 techtonik

You may be right. A new field "browsing URL" would be enough for most cases. (The current GitHub plugin exists not because it needs that url, but because it uses Github's API isntead of locally git cloning the repo)

tobami avatar Jun 25 '11 20:06 tobami

Here is my attempt at implementing this feature. It adds a new field to a project, that will be used to construct the URL for a commit. It will be used by string.format and is passed a single log entry, so you can access fields like {commitid}.

https://github.com/squiddy/codespeed/tree/35_browse_changeset

The first commit is related to #91, I quickly added (it's probably incorrect) that to avoid mixing both changes together.

squiddy avatar Dec 03 '11 17:12 squiddy