tobami
on Changes tab, git revision information overlaps stddev/change/trend columns
0.8 prelease github master
I took a screenshot but github doesn't allow me to attach it to this issue. I can email it directly to you if you wish.
I believe this issue is due to my use of benchmark names that are longer than 30 chars (the limit set in model.py). Sqlite doesn't care if you go over the defined limit but apparently the django view is expecting the names to be shorter.
Many of my benchmark names are 60-80 chars long (they are descriptive rather than just a simple name like "fixnum").
It would be nice if the page reflowed based upon the benchmark name. To keep things sane, it should probably wrap the name if it exceeds a certain number of chars (e.g. 80).
In the interim, I would be grateful if someone could tell me which template to modify to make it wider.
You are correct that the problem appears because you use long benchmark names.
There are several reasons that this has no easy answer. Packing that much information on screen at the same time for different widths is very difficult. Just allowing variable width won't resolve the issue. Further, long benchmark names will overflow the left column (tool box) no matter what.
Codespeed actually tries hard to accommodate the info into various screen sizes. To know what I mean, slowly reduce the width of the browser window. You will see how the layout adapts even to Netbook/Pad sizes, which is a great feature to have (media queries are used for that).
Still, the dynamic layout is not perfect, and there are corner cases where it overlaps. We could try to come up with a variable width table + rev info box.
As you asked, I played around with widths, and found out what you can tweak for the time being.
In media/css/main.css, line 239, you can increase the width of the whole left div column, which contains the changes table.
For example from 30em to 35em:
div#contentwrap div.leftcolumn { width: 35em; }
Okay, but that's not exactly the piece that I need to move. The box that displays the git status, revision and last log message is the one that is overlapping the changes table. How can I move that second table further to the right?
If this isn't clear, I can send you the screenshot.
It's the "Revisions" table that is supposed to be placed to the right of the Benchmark/Time/Stddev/Change/Trend table.
There are two columns. The table is overflowing the left column, and the revision info (right column) is floating to the right of the leftcolumn, which is narrower than the overflowing table. That is the reason that they overlap.
Changing that width will prevent that. Just try ;-)
Ah, you are right. I had to restart the browser for it to pick up that change.
Thanks for the temp fix!
You are welcome. Did you try to "emulate" smarphone-like widths? (800-900px)
No, I didn't. I'm moving on to the next piece so that I can get this deployed tonight (or tomorrow morning).
I understand. Configuration and deployment is not as good or easy as it could and should. That will be a focus for the 0.9 release cycle.
@chuckremes does https://github.com/tobami/codespeed/pull/43 fix your issue? It works at least for me.
I'll check it today and post my results.
On Jun 22, 2011, at 8:16 PM, smarr wrote:
@chuckremes does https://github.com/tobami/codespeed/pull/43 fix your issue? It works at least for me.
Reply to this email directly or view it on GitHub: https://github.com/tobami/codespeed/issues/31#issuecomment-1422399