codespeed icon indicating copy to clipboard operation
codespeed copied to clipboard

Completely refreshing a timeline with an active benchmark leads to a crash when the benchmark name has a space

Open sgraf812 opened this issue 7 years ago • 1 comments

In our project, we have benchmark names such as "Parser-Test 1", with a space in the benchmark name.

When I hit Ctrl+F5 (or close the tab and re-open it with Ctrl+Shift+T) in the timeline view for such a benchmark, the benchmark becomes unselected and I get notified via E-Mail that there was a crash in codespeed here: https://github.com/tobami/codespeed/blob/73412054d77c818ee5b26748cca387ac2e21a040/codespeed/views.py#L257, apparently because there's no entry for 'ben' in the data dictionary. The request URL doesn't seem to contain the 'ben' entry at all.

If I remove the space from the name, e.g. "Parser-Test", everything works as advertised.

sgraf812 avatar Nov 07 '18 17:11 sgraf812

It would be best to move to using ids in the url parameters to avoid this kind of problems.

tobami avatar Dec 13 '18 10:12 tobami