codespeed icon indicating copy to clipboard operation
codespeed copied to clipboard

Equidistant timeline plots display too many ticks

Open tobami opened this issue 12 years ago • 7 comments

See example on speed.pypy.org.

tobami avatar Sep 22 '12 09:09 tobami

Have you made any progress on this? Because the equidistant view of benchmark timelines also has commit dates overlapping. I can attempt to work on it if you have any pointers about where to start. Thanks

philangist avatar Jul 29 '13 18:07 philangist

No work on this yet, no, would be great if you have a look. Pointers:

  • I would actually first look at jqplot itself. Our version is 2 years old, there has been a 1.0 release since then. Just upgrading can fix many things (and break!)
  • Possibly just setting the proper options should do it. Where the plot axis are set in the code

tobami avatar Jul 29 '13 20:07 tobami

Hey, this is a bit of a stupid question, but I feel like I'm missing something obvious. The changes I'm making in timeline.js aren't actually rendering in the timeline view. This includes setting tickOptions to {formatString:'%b %d', angle: -30} and deleting random parts of the .js file (which should cause errors). I thought that the file might be getting cached by my browser so I cleared my cache (and restarted my local codespeed instance) but that's not helping. I'm still a js noob so I'd appreciate any direction.

philangist avatar Aug 01 '13 19:08 philangist

Could it be that you are running runserver.py from codespeed/sample_project but the codespeed app is not codespeed/codespeed but a pip installed one? (and thus not the code you are actually editting)

tobami avatar Aug 01 '13 21:08 tobami

You were right dude. Anyway I got the equistant flag working in the timeline view, but it's very very hacky. I'm sure there is a better way to handle it, but it works for my needs. I had to remove the option to turn equidistant on/off, and change the formatting for dates, but other than that I don't think I broke anything. I'll submit a PR, not for you to merge but hopefully so that either you (or someone else who wants to work on this issue) can have a starting point to work from.

I am curious though, why not just have only the equidistant view from the start, what's the point of allowing DateAxisRenderer in the first place?

philangist avatar Aug 05 '13 21:08 philangist

For anyone who runs into this in the future and wants to see my code, the PR is here and my branch is here

philangist avatar Aug 05 '13 21:08 philangist

Great, thanks, I'll have a look at it and try to integrate it without removing the option.

As to what's the point, you may be right that is not needed, though I'm not really sure. DateAxisRendere gives you extra information, that is how much time has passed between successive data points. We could ask around, maybe there are users that need that.

tobami avatar Aug 06 '13 19:08 tobami