tobac icon indicating copy to clipboard operation
tobac copied to clipboard

Published 20 hours ago • verified publisher icon tobac-project

Sort `threshold` in Feature Detection

Open freemansw1 opened this issue 2 years ago • 1 comments

In feature detection, we don't sort threshold, leading to different behavior depending on how the user has ordered things. Given that we know we want to go from less extreme to more extreme (and the user is required to include target), I think we should sort these.

This comes from a conversation with Yuliya Selevich and Johnny Luo at CCNY

freemansw1 avatar Jul 25 '22 21:07 freemansw1

Agreed, that is a good point and easy to fix.

JuliaKukulies avatar Jul 26 '22 07:07 JuliaKukulies

This will be fixed in v1.4.0 with the merging of #199

freemansw1 avatar Nov 15 '22 13:11 freemansw1