tobac icon indicating copy to clipboard operation
tobac copied to clipboard

Published 20 hours ago • verified publisher icon tobac-project

Resetting parameters in linking_trackpy

Open snilsn opened this issue 3 years ago • 3 comments

I have been working a lot lately with linking_trackpy() for my notebook about linking, and I have a suggestion:

I think the values for MAX_SUB_NET_SIZE and MAX_SUB_NET_SIZE_ADAPTIVE, which are controlled by the subnet_size keyword, should be reset after each function call.

The values of these parameters are stored globally. Therefore, this can lead to undesired behavior if linking_trackpy is called multiple times.

snilsn avatar Jul 25 '22 08:07 snilsn

Yes, completely agreed with this! I'd go as far to say that we should call this a bugfix, but I'm not sure how urgent it is... For now I've milestoned it for 1.4. Given that you fixed the original implementation of this, I'd be happy for you to submit a bugfix, or I can do that!

freemansw1 avatar Jul 25 '22 21:07 freemansw1

I will do the bugfix!

Can I do this along with adding the exceptions for #164?

snilsn avatar Jul 27 '22 14:07 snilsn

I am happy for you to do both bugfixes in the same PR, yes!

freemansw1 avatar Jul 27 '22 18:07 freemansw1

This has been resolved with #168

freemansw1 avatar Sep 09 '22 16:09 freemansw1