vsfire icon indicating copy to clipboard operation
vsfire copied to clipboard

Couple of fixes!

Open ftzi opened this issue 5 years ago • 4 comments

fixes:

"aaa.bbb()": bbb() was highlighted as a variable.parameter. Now is a function.

Functions now allow '_'. Also, allow numbers after the first character.

Functions used as another function parameter were sometimes tagged as variable parameter.

Functions now can have spaces until the parentheses.

Fixed coloring of various matches, as the Function parameters patterns were overlapping them.

Added missing basic types (number, list, map, latlng...)

in a type cast, like int(5), the type gets colored

Fixed #22

ftzi avatar Nov 10 '19 04:11 ftzi

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   40.78%   40.78%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       39       39           
=======================================
  Hits           62       62           
  Misses         82       82           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2066bff...2a6621d. Read the comment docs.

codecov[bot] avatar Nov 10 '19 04:11 codecov[bot]

@SrBrahma Thanks for this PR! I have nothing to do with this project, but I appreciate the fixes!

Any chance you have a link or knowledge of how best to use your master instead of the version in the vscode marketplace?

Thanks!

mkeedlinger avatar Feb 28 '20 21:02 mkeedlinger

I have no idea... Never thought that was possible, and maybe it isn't... I will search about it later.

Thanks for the thanks! :)

On Fri, Feb 28, 2020, 18:30 Michael Edlinger [email protected] wrote:

@SrBrahma https://github.com/SrBrahma Thanks for this PR! I have nothing to do with this project, but I appreciate the fixes!

Any chance you have a link or knowledge of how best to use your master instead of the version in the vscode marketplace?

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/toba/vsfire/pull/23?email_source=notifications&email_token=AGW7JDXB2HVD6BI5FLCLUA3RFF7AVA5CNFSM4JLKZ3L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKHNGA#issuecomment-592737944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGW7JDU7N5SPEKZQKUS4GFTRFF7AVANCNFSM4JLKZ3LQ .

ftzi avatar Feb 28 '20 21:02 ftzi

Oh maybe I was unclear, I mean just loading it into vscode manually (probably the same way you used to test your changes).

A quick Google search found this I'll try it next week when I'm back in office :smile:

mkeedlinger avatar Feb 28 '20 23:02 mkeedlinger