EfficientDet.Pytorch icon indicating copy to clipboard operation
EfficientDet.Pytorch copied to clipboard

Double normalization in weighted feature fusion

Open oadams opened this issue 5 years ago • 2 comments

In BiFPN.forward() the feature weights are normalized:

https://github.com/toandaominh1997/EfficientDet.Pytorch/blob/fbe56e58c9a2749520303d2d380427e5f01305ba/models/bifpn.py#L178-L180

In calculating the bottom up and top down features, it appears this normalization is done again unnecessarily:

https://github.com/toandaominh1997/EfficientDet.Pytorch/blob/fbe56e58c9a2749520303d2d380427e5f01305ba/models/bifpn.py#L190

https://github.com/toandaominh1997/EfficientDet.Pytorch/blob/fbe56e58c9a2749520303d2d380427e5f01305ba/models/bifpn.py#L196

oadams avatar Jan 21 '20 17:01 oadams

@oadams Hi guy, I also find this issue and I believe this can cause big problem. Did you try training the model without changing this part?

XiaoyuShi97 avatar Jan 28 '20 17:01 XiaoyuShi97

@Shi-Xiaoyu No, I never actually trained the model using this code, I was just reading the code.

oadams avatar Feb 23 '20 09:02 oadams