Matthew Toseland

Results 63 comments of Matthew Toseland

Something can go wrong when changing from encrypted to non-encrypted and vice versa. We want to be able to recover from this case. Hence we need to try both. Also...

Okay so: - If we are expecting it to be encrypted we should try the encrypted file first. (BUG, we always try the unencrypted one first at present) - We...

This seems to work on my node and also in synthetic tests (RealNodeRequestInsertTest and RealNodeULPRTest). Please consider for merging into a test release. It should greatly reduce the number of...

Unfortunately this might be affected by issues in #400. One possibility is to leave out the last commit but I'm concerned about memory usage. So this might be blocked... :(

Not IIRC, although it should be tested carefully, especially in vitro.

Merged next into the branch. Please consider for 1472.

This needs to be looked at very carefully if we're actually going to use it. The crypto code that I merged in purge-db4o-crypto had some serious bugs and API issues.

There was at least one serious bug, see the comments on devl. But yes, all I mean is be careful - and note that poor APIs can cause serious bugs;...

[forms-bug.permissions-hack.clean.diff.txt](https://github.com/user-attachments/files/17091462/forms-bug.permissions-hack.clean.diff.txt) After further debugging, we have a workaround (patch), but I'm not 100% sure whether it is safe. What is actually happening here is an interaction between several apps: -...

I've created a pull request for a shorter version of the patch: https://github.com/nextcloud/server/pull/48295 Note that this is against server, so I'm not sure whether I need a server ticket? I...