Tomáš Nožička

it should keep the custom annotations https://github.com/scylladb/scylla-operator/blob/5257bd6da9bda02eca588ab20c7eea988681e5df/pkg/resourceapply/core.go#L75

I think adding meta is useful but with that level or granularity it becomes a bit hard to easily express it on the CRD. Not impossible though. > Other operators...

The Three Laws of controllers are described here https://github.com/kubernetes/design-proposals-archive/blob/main/api-machinery/controller-ref.md#the-three-laws-of-controllers In your case that means pre-creating a service with your annotation and the same selector. What I meant is that annotations...

unfortunately, I don't

thanks, for the review (first round of comments addressed)

> @tnozicka are the new feature flags going to be expose in the helm chart ? (i.e. in SCT we are deploying using the helm chart) Not in this PR...

I forgot to sort the cert inputs, that explains the latest flake ```    IPAddresses: []net.IP{ -  s"10.101.162.44", +  s"10.102.200.4", -  s"10.102.200.4", +  s"10.101.162.44",    }, ``` @zimnx fixed squashed, the diff...

another notable change is aggregating conditions and verifying them https://github.com/scylladb/scylla-operator/compare/cb6c29f846290e8353521fa25fa7ea601c41862c..1871d38b04dde4723d83ae70fc122eb579ee7a41 This is needed for future work that will add a scaling condition whose aggregation will prevent considering a rollout done...

flaking a lot, last one in https://github.com/scylladb/scylla-operator/actions/runs/3086220438/jobs/4990391763#step:12:559 https://github.com/scylladb/scylla-operator/suites/8367743162/artifacts/369018669

I saw this flake quite often today, one of them was https://github.com/scylladb/scylla-operator/actions/runs/3204391810/jobs/5235672421#step:3:1650