ngx-joyride icon indicating copy to clipboard operation
ngx-joyride copied to clipboard

Optimize backdrop rendering

Open VladimirAnaniev opened this issue 4 years ago • 1 comments

Noticed that the backdrop was removed and then re-drawn on each step of the tour.
These operations for removing and then creating new DOM elements are expensive and can be avoided as only a couple of styles are changed. We can only update the needed properties when needed.
Other benefit of reusing the same elements is the ability to incorporate animations on transition later.

I have implemented this optimization with this change.

VladimirAnaniev avatar Sep 06 '19 16:09 VladimirAnaniev

Hello @VladimirAnaniev , Thanks for your PR. Can you please resolve the conflicts?

tnicola avatar Mar 13 '20 07:03 tnicola