samlify Refactor to support encrypted assertions

Support encrypted assertions which was broken during security patch

May 26 '25 16:05 ahacker1-securesaml

@h-bragg, @tngan , can you help review this PR.

To run tests we need to: yarn add @authenio/samlify-xsd-schema-validator yarn run build

Now this passes all the test cases. (last time, I forgot to run yarn add schema validator, which is why it didn't detect the failing test cases for the encrypted assertions).

To review: extractor depends solely on verified XML i.e. getSignedReferences()

May 26 '25 16:05 ahacker1-securesaml

@mastermatt do you plan on proposing any new changes i.e. error handling. If not, I will apply the current feedback and then start the release process for a new version.

May 31 '25 08:05 ahacker1-securesaml

This is also breaking for services our teams use that leverage encrypted assertions, and we will not be able to bump until this is released.

Jun 03 '25 15:06 avocadojesus

Ok, I will ask maintainer to release this.

Jun 03 '25 17:06 ahacker1-securesaml

I'm fine with the new error handling, I just wanted to make sure it was understood that thrown errors have changed. Whether intentional or not.

Jun 03 '25 22:06 mastermatt

This is also impacting us, thanks for putting together a fix so quickly.

Jun 04 '25 16:06 noahg

Maintainer tngan, says he will review over the weekend. In the meantime, I recommend sponsoring him: https://github.com/sponsors/tngan

Jun 06 '25 07:06 ahacker1-securesaml

bugbot run

Jun 06 '25 13:06 tngan

bugbot run

@tngan looks like this failed, thanks for the help

Jun 13 '25 16:06 noahg

@tngan is there a path to getting this live? Anything we can do to help get it over the line?

Jun 27 '25 19:06 davecardwell

@davecardwell There's a sponsor link: https://github.com/sponsors/tngan

Here are the tiers:

$50 a month
🎩Professional - feel free to consider this tier if you are an individual and you use my work for a commercial product that is ready for sale.

I will prioritise your requests and issues on my open source projects

$100 a month
👥Partner - feel free to consider this tier if your team and your company use my work in your products.

I will

prioritise your requests and issues on my open source projects
review some of your projects and help you improve

Jun 27 '25 20:06 ahacker1-securesaml

Why don't we see the 2.10.1 version as the last release on github but we do see it on npm? Thank you,

Sep 05 '25 12:09 GuillaumeCisco