samlify icon indicating copy to clipboard operation
samlify copied to clipboard

createLoginRequest serializes undefined ACSUrls

Open logancarmody opened this issue 4 years ago • 1 comments

For a given protocol, if the ACSUrl is undefined, createLoginRequest serializes this undefined ACSUrl. Some IdPs like Google can't handle the serialized undefined.

I discovered this because I was misconstructing the Service Provider, so this was based out of user error. However, I don't think this is the correct behavior. I think the lib should either:

  • Throw an exception
  • Don't serialize the ACSUrl at all since it's optional in Saml2.0

logancarmody avatar Oct 25 '21 14:10 logancarmody

@logancarmody Thanks for your advice, I agree that the construction process is not that straightforward right now, we will simplify and enhance with more restricted validation when we restructure the v3 API.

tngan avatar Nov 07 '21 17:11 tngan