libtmux

libtmux copied to clipboard

Strict detection of tmux version via regex

4

See: #396 This change uses a more precise regex method to grab the tmux version string, taking into account the many variations of tmux versions: ``` # tmux 3.3a ·...

mdeguzis

libtmux is picking up the wrong tmux version

14

See: https://github.com/tmux-python/tmuxp/issues/794 Started new server, protocol mismatch. tmuxp seems to be using /usr/bin/tmux instead of what I have aliased. ``` $ tmux -V tmux.orig 2.8 $ /usr/bin/tmux -V tmux 1.8...

mdeguzis

Dataclasses

1

#370

tony

Use `packaging` for `Version`

1

Compare to #349

tony

Custom, flexible `Version` implementation

1

tony

Use `packaging` for `LegacyVersion` / `LooseVersion`

1

Ongoing issue: - python 3.10 raises warnings with distutils - In [`packaging`](https://packaging.pypa.io/), `LegacyVersion` (the supercessor to `LooseVersion`) will be deprecated, we won't be able to support `2.4-openbsd` (like what is...

tony

Trying to get a compliant, typed version parser/comparator

5

Companion: https://github.com/tmux-python/tmuxp/pull/727 See also: - https://github.com/asottile/flake8-typing-imports/blob/923a533/flake8_typing_imports.py#L32-L42 - https://github.com/pypa/packaging/blob/5984e3b25/packaging/version.py#L444 - [x] String comparison's against `Version` @layday's [snippet](https://github.com/pypa/packaging/issues/465#issuecomment-1013715662) - [ ] LegacyVersion deprecation In [`packaging`](https://packaging.pypa.io/), `LegacyVersion` (the supercessor to `LooseVersion`) will be...

tony

Split init / exec of tmux_cmd for debuggability

3

_Edit 2022-08-14 by @tony : This is very similar to [`SubprocessCommand`](https://libvcs.git-pull.com/internals/subprocess.html#libvcs._internal.subprocess.SubprocessCommand) ([source](https://github.com/vcs-python/libvcs/blob/v0.14.0/libvcs/_internal/subprocess.py))_ tmux_cmd initialization composes the command the command will be available in the instance attribute `.cmd` `.execute()` instance method...

tony

This can cause tricky circular imports / cyclic dependency issues that get in the way of mypy, [MonkeyType](https://github.com/Instagram/MonkeyType), and our API documentation. Looking for feedback on this. Is it a...

tony

Typed annotations / data structures

1

Next milestone add these for all objects [`TypedDict`](https://peps.python.org/pep-0589/) w/ [`total=False`](https://peps.python.org/pep-0589/#totality) may be a good contender for object structure as its standard library 3.8+ and 3.7 and 3.8 will be dropped...

tony