tmux-resurrect
tmux-resurrect copied to clipboard
tmux-plugins
Restoring pane title
Hi,
I made a little improvement adding the restoring of pane title. Simply, I added #{pane_title} to pane_format and tmux select-pane -T <title> in restoring.
This PR will fix also issue #330
Tried this patch , named titles are saved and restored , howevers panes with empty titles are restored with current directory path . Can you please fix that too ?
I too would really appreciate if this PR can be introduced. I took several hours to make 'panestankingly' create a beautiful system dashboard with each pane having a descriptive title. When I used tmux-resurrect and restored my session, all that work was lost.
This was quite unexpected as I thought tmux-resurrect saves all the little details from your tmux environment so it can be completely restored after a system restart and pane titles have been around for quite a while now.
I set this in my ~/.tmux.conf set -g pane-border-status top
to set the title of each pane: tmux select-pane -t 1 -T title2
Could someone with experience look at the branch conflict and see what the problem is to introduce this basic feature?
Hi,
I'm in favor of adding this feature, but I don't have time to work on it.
I'll provide support and guidance if anyone is willing to step up and take the ownership of this feature. The code changes in this PR should already work so the next steps would be:
- Rebase with
master - Address PR comments
- Test, test, test
- Merge if all looks good
Hi @bruno-, I'll take care of this PR. Can I somehow continue in this PR or do I have to create a new one?
Just a note - for easier migration, I'll check number of saved pane parameters since you don't want the pane title to be last.
I'll take care of this PR
Great!
Can I somehow continue in this PR or do I have to create a new one?
Not sure, I think you have to create your own.
for easier migration, I'll check number of saved pane parameters since you don't want the pane title to be last.
We don't want to litter the plugin source code with migration logic. I'd prefer the pane_title parameter to be on line 51.
We don't want to litter the plugin source code with migration logic.
That's a valid point, noted.
I'd prefer the pane_title parameter to be on line 51.
Line 51 has delimiter on it, did you mean 52?
FYI: There is a bug in restore.sh on line 281 in restore_shell_history() function, there should be $11 instead of $10 since in this version, there is still window_name saved with each pane.
https://github.com/tmux-plugins/tmux-resurrect/blob/5c69748392decb52383c41edb0294ba68d9f5025/scripts/restore.sh#L281