moosh icon indicating copy to clipboard operation
moosh copied to clipboard

Moosh Deprecation warning (git install)

Open JedMeister opened this issue 4 years ago • 1 comments

  • moosh version: commit b6f57a747aab744a22192e8fe4c0839e371eaa47 (current HEAD of master)
  • moodle version: None (yet)
    • database: MariaDB 10.3.22 (Debian package: 10.3.22-0+deb10u1)
  • php version: 7.3 (Debian package: 7.3+69)
  • operating system: Debian 10/Buster

Actual behaviour

# git clone git://github.com/tmuras/moosh.git
Cloning into 'moosh'...
[...]
# cd moosh
# composer install
Deprecation warning: require.jamiepratt/moodle-qtype_TEMPLATE is invalid, it should not contain uppercase characters. Please use jamiepratt/moodle-qtype_template instead. Make sure you fix this as Composer 2.0 will error.
[...]

Expected behaviour

# git clone git://github.com/tmuras/moosh.git
Cloning into 'moosh'...
[...]
# cd moosh
# composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
[...]

Steps to reproduce

As per "Actual behaviour"

Fix:

diff --git a/composer.json b/composer.json
index 3232970..9b39dd0 100755
--- a/composer.json
+++ b/composer.json
@@ -66,7 +66,7 @@
       "type": "package",
       "package": {
         "version": "dev-master",
-        "name": "jamiepratt/moodle-qtype_TEMPLATE",
+        "name": "jamiepratt/moodle-qtype_template",
         "source": {
           "url": "https://github.com/jamiepratt/moodle-qtype_TEMPLATE",
           "type": "git",
@@ -213,7 +213,7 @@
     "twig/twig": "1.18.2",
     "moodlehq/moodle-mod_newmodule": "dev-master#e1f112be8842291259ece87de3000cd5f0e18711",
     "danielneis/moodle-block_newblock": "dev-master#1fc89fb0845ad282426140feeb6bc3653efd1d7f",
-    "jamiepratt/moodle-qtype_TEMPLATE": "dev-master",
+    "jamiepratt/moodle-qtype_template": "dev-master",
     "danielneis/moodle-gradereport_newgradereport": "dev-master#691f53a15de352c3fe25da03c001a97a76b18358",
     "moodlehq/moodle-local_wstemplate": "dev-master#add2ad0949e72f025c0aad36c4b822e8c6479d3b",
     "yetanotherape/diff-match-patch": "dev-master#0726dbb4e59e68574326821c174013cf6fdfe20e",

I would have opened a pull request but I'm not that familiar with PHP, Composer or Moosh, so figured it best to let the experts take care of that. If a pull request is preferred, please let me know and I'll be happy to do one...

JedMeister avatar Jun 16 '20 03:06 JedMeister

Hi @tmuras ,

I am experiencing the same issue with installing Moosh.

$ composer.phar install --no-interaction --no-ansi --optimize-autoloader

Deprecation warning: require.jamiepratt/moodle-qtype_TEMPLATE is invalid, it should not contain uppercase characters. Please use jamiepratt/moodle-qtype_template instead. Make sure you fix this as Composer 2.0 will error.

michael-milette avatar Oct 21 '20 13:10 michael-milette