mpw-js icon indicating copy to clipboard operation
mpw-js copied to clipboard

Password generated in Edge is different to other implementations

Open leemeichin opened this issue 8 years ago • 8 comments

Full name: Robert McTables
Master Password: correcthorsebatterystaple
Site: github.com

In Edge 14:

Password: Luzz0/CedkSowi

In Safari/Chrome + Non-web versions:

Password: QonoTosbQepv1=

leemeichin avatar Oct 03 '16 19:10 leemeichin

Can you post the output of https://tmthrgd.github.io/mpw-js/test/?

tmthrgd avatar Oct 05 '16 04:10 tmthrgd

Sure! It looks like there's an error with the test itself:

mpw_1 mpw_2

leemeichin avatar Oct 05 '16 07:10 leemeichin

@leemachin That error shouldn't have prevented the test suite from functioning, but either way, it has now been fixed (see #9). Would you mind running the test suite again for me?

tmthrgd avatar Mar 26 '17 08:03 tmthrgd

was curious to help and check in my dual core W10-64 pro 1809 system.

MS Edge 44.17763.1.0 / EdgeHTML 18.17763 completely fails right away. GC 72.0.3626.81 (64-bit) passes 23sec. Fx 60.5.0esr (64-bit) passes 2min23sec.

(seems like Fx doesn't soak up the cpu power until almost the end).

jmichael2497 avatar Feb 05 '19 05:02 jmichael2497

@jmichael2497 Thanks for the update. Is there any error message from the failure or in the debug console?

tmthrgd avatar Feb 05 '19 09:02 tmthrgd

@jmichael2497 (From memory): The slowdown in Firefox is caused by missing support for the right PBKDF2 algorithm which is instead done partly in JavaScript.

tmthrgd avatar Feb 05 '19 09:02 tmthrgd

@jmichael2497 Thanks for the update. Is there any error message from the failure or in the debug console?

sorry forgot to specify all test lines just end basically with similar variable timings of

"Failed; [object Object] (after 601.4000000000001ms)"

and a quick peek through the built in dev tools did not show any errors or warnings in the console.

i would generally recommend folks use a clean and locked down browser like fx or gc anyway (shrug).

jmichael2497 avatar Feb 05 '19 23:02 jmichael2497

for reference on same dual core W10-64 pro 21H2 system:

  • MS 109.0.1518.78 passes after almost 15.0min
  • GC 109.0.5414.120 passes after almost 1.5min
  • Fx 102.7.0esr passes after almost 1.5min

jmichael2497 avatar Feb 05 '23 00:02 jmichael2497