Tomas Zigo

Results 133 comments of Tomas Zigo

It requires modifying the `GridModule` class [tests](https://github.com/OSGeo/grass/actions/runs/3083608256/jobs/4984743490).

Complex test with https://github.com/OSGeo/grass/pull/2584/commits/3c8d6b851383782774ad69abb8a40c346e8d1f03: 1. SEARCH_PATH file doesn't exists (passed): ``` GRASS nc_spm_08_grass7/landsat:~ > file grassdata/nc_spm_08_grass7/landsat/SEARCH_PATH grassdata/nc_spm_08_grass7/landsat/SEARCH_PATH: cannot open `grassdata/nc_spm_08_grass7/landsat/SEARCH_PATH' (No such file or directory) GRASS nc_spm_08_grass7/landsat:~ > g.mapsets -p...

> No I got confused, didn't you @tmszi change the behavior of g.mapsets in #2586 to avoid writing the newline at the end? Should I revert the last commit in...

Could we move forward with this PR, please?

> I have merged current main into this which refreshes the code base in the PR overall. The PR had some indentation changes included, so the new indented code from...

I can't reproduce it: ``` GRASS nc_basic_spm_grass7/PERMANENT:~ > db.select table=test cat|name|idx 202|forest|1 1279|urban\n|2 1536|agric\nulture|3 GRASS nc_basic_spm_grass7/PERMANENT:~ > cat /tmp/test.py #!/usr/bin/env python3 import grass.script as gs def main(): print(gs.vector.vector_db_select('test')['values']) if __name__...

Commit https://github.com/OSGeo/grass/pull/2567/commits/55dfaf4c5b276c9383654d06fc5469886aaa5ddc and https://github.com/OSGeo/grass/pull/2567/commits/f28483ac63b5e243e2895e451ec6703142ad2c40 handle situation (reset back MAPSET search path and clean temp data) if input map doesn't exists (example bellow **basin** raster map doesn't exists in the current...

With this PR `GridModule` class instance internally extend current MAPSET search path by all accesible LOCATION MAPSETs. Example: When input map name e.g. elevation has unique name across all LOCATION...

> I think GridModule should not modify the search path of the current mapset at all. It should simply use fully qualified names if needed. Yes, I agree with you....

> This is mixing a bugfix and enhancement, so it seems to me the CleanManager should be separated into another PR. There have been changes (#2584) and I didn't test...