muji

Results 108 comments of muji

I think we should try to leverage the [strsim](https://docs.rs/strsim/0.10.0/strsim/) crate for this feature, it would bump the dependencies up for this library to two but `strsim` has zero dependencies so...

That makes a lot of sense @marcus-pousette, I guess with the N-gram tokenizer we are trading memory for speed and using a distance matching algorithm on query keeps the index...

@marcus-pousette, I started to play around with n-gram indexing and it appears to work well. I added these tokenizers to my project: ```rust // Index tokenizer. fn tokenizer(s: &str) ->...

I would prefer to avoid the additional dependency if possible, is it worth us supplying our own `n_slice` function behind an `ngram` feature flag? Edit: if we built our n-gram...

Found [this article](https://en.wikipedia.org/wiki/Approximate_string_matching) interesting.

I think that sorting is better left to the caller that needs to display the results because there are many permutations of sorting requirements. Maybe I am storing dates not...

@luca992, the c-split fixes did have a significant performance impact for DKG (particularly noticeable in webassembly), however I think @ivokub is referring to additional (upcoming) performance impact but happy to...

@luca992 yeh that's not a sensible thing to do and doesn't reflect real world usage, for my webassembly use case I run each party in separate browser tabs and use...

Hi @xcshuan, I think those links show there is not yet consensus amongst cryptographers regarding safe primes and ultimately we are constrained by the WASM runtime environment. It would be...

Also, the note here indicates it is recommended by ZenGo: https://github.com/ZenGo-X/multi-party-ecdsa/blob/c94065fbf37132dccc7955cf2627866e87c162bf/src/protocols/multi_party_ecdsa/gg_2020/party_i.rs#L179-L199 However it's interesting to notice that `create_safe_prime()` calls `generate_h1_h2_N_tilde()` which in turn is ***not*** using the safe prime function...