Tymoteusz Motylewski comments

Results 134 comments of


                                            Tymoteusz Motylewski

Add translation helper shell script

have you checked if n98-magerun has sth similar already?

Optimize count queries by removing all joins if there are no where cl…

what about group by and having ? should it also be taken into account?

Replaced hard coded "new" object creation with Magento friendly way

This kind of change has a significant risk of introducing some side effects. Maybe we are missing some api or event which would make the whole architecture of your extension...

Imagick adapter, handles color profiles better

Nice idea! Please also provide which IM version you have tested it with (different IM versions have different quircks). Maybe a check in the code would also be useful? Do...

Update Mage_Customer_Model_Convert_Parser_Customer method unparse()

Hi @matteorossi-thespacesm Thanks for the PR! Can you please describe the steps I can take to reproduce the issue this PR is fixing? Thanks a lot!

Improve performance of product category rewrites (disabled product & categories and product_use_categories)

@colinmollenhour should be better now :)

Improve performance of product category rewrites (disabled product & categories and product_use_categories)

rebased

Improve performance of product category rewrites (disabled product & categories and product_use_categories)

fixed issues reported by phpstan

Obsolete code in block for configurable products

If I see correctly Its not an no-brainer. The code has several side effects. $this->_preparePrice calls internally Mage_Catalog_Helper_Product_Type_Composite::preparePrice which calls $product->getFinalPrice() and Mage_Catalog_Helper_Product_Type_Composite::registerJsPrice and getFinalPrice sets 'final_price' field on product...

Notes over multiple lines

the same would be great for other labels like component, or evolution