midiparser icon indicating copy to clipboard operation
midiparser copied to clipboard

Issue with Time Signature

Open Balthov60 opened this issue 3 years ago • 0 comments

Hi ! For some reason you transform the denominator of time signature to it's log2 value But when you compute the user friendly time signature you don't revert the denominator correctly, you compute pow($logDenominator, 2) instead of pow(2, $logDenominator)

// Constructor
parent::__construct(array($numerator, log($denominator, 2), $metronomePulse, $thirtySecondNotesPerQuarterNote));

// Time signature computation
public static function getTimeSignature($numerator, $logarithmicDenominator) {
	return $numerator . '/' . pow($logarithmicDenominator, 2);
}
image

Balthov60 avatar Feb 22 '22 09:02 Balthov60