time_difference icon indicating copy to clipboard operation
time_difference copied to clipboard

Published 20 hours ago • verified publisher icon tmlee

Fix: Change activesupport load requirement to address humanize method

Open drubio1989 opened this issue 8 years ago • 2 comments

drubio1989 avatar Oct 03 '16 10:10 drubio1989

Hey @tmlee, I was hoping to merge this pull request that fixes the humanize method issue. I was reading on Travis CI(https://docs.travis-ci.com/user/languages/ruby/) that the syntax for rbx-mode19 isn't supported. I also saw the following text:

'When using Rubinius, there’s currently an issue with selecting the correct version in RVM in our build environment, but only when specifying rbx as your version. As a workaround, specify rbx-2 instead.'

Is it possible that the Travis CI build could be broken which would prevent the merge of this request? I saw on the previous pull requests that the Rubinius builds passed but those were all a while ago. I love this gem and would like to incorporate it if I can with my most recent project. Thanks.

drubio1989 avatar Oct 03 '16 15:10 drubio1989

Hi @drubio1989 many thanks. I have updated the master branch to pass the build. You are right and i have ended up removing rbx from travis. I've tried with different versions of rbx based on the travis documentation and none of them work; decided to drop it. Can you rebase from master and we can see if the build passes for this one.

What would be the consequences in your mind switching from ActiveSupport 3.2 to 4.2 in this PR?

tmlee avatar Feb 28 '17 08:02 tmlee