Thomas M Kehrenberg

Results 112 comments of Thomas M Kehrenberg

On Fri, 2022-03-18 at 05:32 -0700, Oliver Thomas wrote: > Can we consider renaming some methods as well? E.g. `Kamiran` -> > `Reweighting` > Of course!

Yes, that sounds good.

I think Myles considers this to be the implementation: #293 . But it's kind of only one part.

A work-around would be to define a new metric that is the negative of the existing metric. ```python @dataclass class InverseAccuracy(Accuracy): def score(self, prediction: Prediction, actual: DataTuple) -> float: return...

Be sure to use the right reST syntax: https://github.com/wearepal/wiki/blob/main/how_tos/how_to_write_sphinx_docstrings.md#code-blocks

I have code like that in my code base and it executes perfectly fine: ``` Python 3.10.4 (main, Jun 29 2022, 12:14:53) [GCC 11.2.0] on linux Type "help", "copyright", "credits"...

Here is a reproducer without the type annotation: ```python import pandas as pd x = pd.Series({0: 0, 1: 1}, name="my series", dtype=int) assert isinstance(x, pd.Series) ``` mypy: ``` % mypy...

I checked again and I noticed that I can only reproduce it with the `--warn-unreachable` flag: ``` mypy --warn-unreachable pandas_test.py ``` I just did it on mypy 0.981 and with...

@jonyscathe I don't have a solution. My next step was going to be to open an issue in the mypy repository but I wanted to have a smaller reproducing code...

I found a standalone reproducer: ```python from __future__ import annotations import datetime from typing import Any, Generic, TypeVar, Union, overload S1 = TypeVar("S1", int, datetime.datetime) class Series(Generic[S1]): @overload def __new__(cls,...