slick-pg icon indicating copy to clipboard operation
slick-pg copied to clipboard

Replace scala-reflect with izumi-reflect

Open mdedetrich opened this issue 2 years ago • 6 comments

In progress PR of replacing scala-reflect with izumi-reflect with the intention of adding Scala 3 support to slick-pg (scala 3 doesn't support scala-reflect and that is intentional).

mdedetrich avatar Oct 04 '23 12:10 mdedetrich

Currently blocked by https://github.com/zio/izumi-reflect/issues/436

mdedetrich avatar Oct 04 '23 12:10 mdedetrich

@tminglei Do you have an opinion on the linked ticket and what approach should be used?

mdedetrich avatar Oct 04 '23 16:10 mdedetrich

@tminglei are you around?

@mdedetrich my two cents, perhaps instead of trying to mechanically convert the code, maybe we should address the root issue, is reflection really needed to achieve the objectives? Even if it's a breaking change I think it would be better to just get rid of reflection.

nafg avatar Oct 18 '23 08:10 nafg

I don't think izumi-reflect can do everything we need here. Have opened a pr to get the rest of the scala 3 support over the line in the hope that the Struct stuff can be implemented maybe with a macro or something...

hughsimpson avatar Nov 29 '23 17:11 hughsimpson

@hughsimpson amazing

nafg avatar Dec 04 '23 10:12 nafg

@nafg @mdedetrich Have implemented Struct support using inline in the scala 3 branch now, which I think will make this pr redundant. Was very useful starting point though 🙏

hughsimpson avatar Dec 07 '23 18:12 hughsimpson