Tzvetan Mikov
Tzvetan Mikov
@leotm to my embarrassment, I have to profess my ignorance and admit that I haven't really followed SES closely. Frankly, at this point Hermes has gaps in EcmaScript compliance that...
FWIW, I think we might be able to add support for `with`. It feels wrong to completely ignore a language feature that has been with us for many years. It...
Hi, thank you for reporting this. As described [here](https://github.com/facebook/hermes/blob/e2f48291e4635b230c1267a77c05ea8efe216725/doc/Features.md#miscellaneous-incompatibilities), Hermes implements Promise by using the Promise polyfill https://github.com/then/promise, which unfortunately isn't fully compliant. This was done to ensure compatibility with...
@ljharb It is certainly worth looking into. Two quick questions if you don't mind: - AFAICT, the Promise shim isn't separated. Do you think it would be feasible for us...
@ljharb offer much appreciated, thank you! I will reach out in the es6-shim repo if we need help. Changing the Promise implementation is a very risky process, I don't think...
As was mentioned before, unfortunately we can't easily patch 01-Promise.js, since it is automatically generated from https://www.npmjs.com/package/promise by https://github.com/facebook/hermes/blob/8dc886dabfe2fa90614294b23d08c845243300b8/utils/gen-promise-internal-bc.sh . We were forced to use it for compatibility with React...
> Perhaps that is a question for the Hermes team, Is there prior art of a partial implementation like this in Hermes? There have been quite a few issues like...
@paulmillr yes, I understand that this is annoying. But crypto is not provided by any other JS engine either, so I hope you also understand that this is not something...
@paulmillr I disagree that "CSPRNG takes 10 lines of code and basically no time to maintain". It needs an implementation for Linux, Windows, MacOS+iOS and Android. On Android it has...
@paulmillr @LinusU I agree that this is a problem that needs to be addressed. To be constructive, I am proposing the following compromise solution. We will review and if it...