Tomás Migone
Tomás Migone
L2 work now lives at: - #699 - Bridge - #700 - Linear rewards - #701 - Drip rewards
@abarmat I'll work on addressing your comments but I think you didn't review the latest commit, I think you were on `6087247` (see https://github.com/graphprotocol/contracts/pull/670/commits). I only noticed because there are...
@abarmat, I'll reply to your comments now. Note that you didn't review the latest commit but an intermediate one. Some of your comments were addressed by later commits. In any...
Commits from this PR have been cherry picked into https://github.com/graphprotocol/contracts/pull/703 Closing PR.
> @tmigone what are the empty config files under `gre/test/files`, are those for existence tests? Exactly. The tests are mainly to verify the plugin does path resolution correctly since there...
See #578 for an example.
This worked on my machine with macOS Monterrey 12.5.1: ```bash [ -f $LOCKFILE ] && ps -p "$(< $LOCKFILE)" -o args= | grep -F " ${BASH_SOURCE[0]}" && kill "$(< $LOCKFILE)"...
Can confirm I had to `chmod +x ~/.tmux/plugins/tmux/scripts/network_ping.sh` for it to work. I'm on macOS
> I tried running the e2e locally, it worked OK when doing L1 only, then I set the L2_NETWORK variable to localhost and got some errors, I'm not sure how...
Fixed the error! About the documentation reference, the GRE README.md mentions the plugin and links to it already, do you think we should add more?