Add spectral blades to mage immunity class

[ram6ler]

Hi,

What an epic game! Thanks for your continued development on BrogueCE!

Just to let you know, when when playing version CE 1.10.1 seed #296201188 I found something that might be a bug: the +3 chain mail of mage immunity (found around the center of depth 2) claims to "offer complete protection from any attacking goblin conjurer..." (etc.) but doesn't prevent damage from goblin conjurers' spectral blades (e.g. the conjurer encountered near the entrance in depth 3).

[apgove]

I think the behavior is intended and consistent, in the same way that a staff of conjuration is effective against reflective enemies. But I agree the wording could be improved. The same applies to liches, which can't harm you directly but will still kill you with summons.

Maybe something like "offers complete protection from any attacking X (but not their summoned allies)"? Or perhaps "offers immunity against any direct attacks from X"?

[tmewett]

Thanks for the report. As apgove says, this is intended, but I would accept patches to improve the wording. It seems more obvious for summons which are actually monsters, instead of spectral entities which may seem more like spells.

[nstoddard]

It looks like armor of goblin immunity does protect you from spectral blades: https://github.com/tmewett/BrogueCE/blob/master/src/brogue/Globals.c#L2172. Should that be changed?

[brentoboy]

Personally, I consider summoned blades as spell, not an ally. And someone immune to mage attacks would be immune to them. Just like they can be negated, but summoned allies cant. Furthermore, I think the duration of the spell should be limited to a dozen or two rounds, perhaps lasting longer at higher enchants.