BrogueCE
BrogueCE copied to clipboard
tmewett
potion of strength won't heal old weakness if you are weakened on the same turn?
I haven't encountered this in BrogueCE yet, only in RapidBrogue, but it looks to me like it will also arise in BrogueCE.
If you are already weakened (say: Weakened: -2) and you drink a potion of strength, the immediate effect of the potion of strength is to set the weakness timer to 1. Ordinarily that means that the weakness immediately wears off at the end of that turn. However, if you are hit the same turn by a weakening attack, that resets/increases the weakness timer, so you do not get the benefit of the potion of strength.
That is, the behavior I expected is: Rogue with base strength of 13, Weakened -2 to 11 -> potion of strength sets base strength to 13 and Weakness to 0 -> attack sets weakness to -1, so resulting adjusted strength is 12. The behavior that resulted in RapidBrogue, and I think here, is: Rogue with base strength of 13, Weakened -2 to 11 -> potion of strength sets base strength to 13 and weakness timer to 1, leaving weakness at -2-> attack increases weakness timer to 30 or 31 and increases weakness to -3, so resulting adjusted strength is 10.
This might be intended behavior--I guess if it is, it's hard to communicate in-game.
is the proposed fix updating potions of strength to set weakness to 0, rather than weakness timer to 1?
That is, the behavior I expected is: Rogue with base strength of 13, Weakened -2 to 11 -> potion of strength sets base strength to 13 and Weakness to 0 -> attack sets weakness to -1, so resulting adjusted strength is 12.
If Rogue is Base Str 13, doesn't the Pot of Strength increase base to 14, regardless of weakness?
I am 14 -1 = 13 I drank the potion. Same turn the centipede hit me. I am now 15 -1 = 14.
The log in the screenshot, the red box is everything that happens on one turn. I know I have initiative so I'm not surprised by this. And technically I get a benefit of the reduced strength requirement. I would normally save my Strength until after the battle but if I was desperate to increase my hit probability, I might consume during a battle.
So I don't think it's a bug but you could argue that the potion should have the effect on that turn and ensure no weakness occurs in that turn?
