Flurl icon indicating copy to clipboard operation
Flurl copied to clipboard

Remove Circular Redirect Detect

Open RecordingTheSmile opened this issue 1 year ago • 1 comments

Now that we can limit the max redirect count, I don't think mandatory detection of circular redirects is necessary. And there are indeed many website functions that rely on circular redirection (login, for example).

So I think we can remove the Circular Redirect Detect or at least add a switch.

RecordingTheSmile avatar Sep 11 '22 14:09 RecordingTheSmile

Hmm, yes I think I agree. I could definitely see redirects A -> B -> A as part of an auth flow, and it does look like Flurl will throw if it detects that. I'll get it on the roadmap for 4.0.

tmenier avatar Sep 15 '22 21:09 tmenier

Any updates on this? This exception is preventing me from implementing something in a project of mine. I know I can use the standard System.Http library in the meantime, but I'd like to use Flurl if possible.

Decimation avatar Nov 14 '22 06:11 Decimation

@tmenier Are you going to remove this feature? If yes, I can submit a PR.

RecordingTheSmile avatar Nov 14 '22 07:11 RecordingTheSmile

@Decimation @whl2606555 This issue wasn't a high priority relative to the roadmap. But it's an easy one, so if it's causing you pains and you're willing to use a prerelease version, I'll get it out in the next 4.0 prerelease, which I plan on working on very soon.

tmenier avatar Nov 16 '22 15:11 tmenier

@tmenier Yes, that would be helpful.

Decimation avatar Nov 16 '22 22:11 Decimation