Flurl icon indicating copy to clipboard operation
Flurl copied to clipboard

Sonarcloud

Open asienicki opened this issue 5 years ago • 7 comments

Hi,

I "forked" repo ~30 minutes ago and I sent report from dev branch to sonarcloud. Here is the result: https://sonarcloud.io/dashboard?id=asienicki_Flurl Sonarcloud found a few issues ;)

appveyor.yml changed: https://github.com/asienicki/Flurl/commit/7d9b0f4455638fd3b2583c2599e5a70375841eaa

What do you think about adding sonarcloud to your project? :)

#oneMoreBadge ;)

asienicki avatar Apr 03 '19 19:04 asienicki

I'm not seeing anything particularly useful here, and I definitely wouldn't call this an "issue". Thanks though.

tmenier avatar Apr 03 '19 20:04 tmenier

"Feature request" is equals label.enhancement in your project.

Ofcourse SonarQube is only nice to have *feature.

asienicki avatar Apr 03 '19 21:04 asienicki

Do you work for Sonarcloud? If not I apologize, but this just felt a little "spammy" to me.

tmenier avatar Apr 03 '19 21:04 tmenier

Definitely not, but I consider this platform to be a good initial determinant of whether to use an open source project or not.

Projects with static code analysis are more reliable. In addition, this platform is more and more popular lately. It is harnessed to the entire software development process.

Too much code smells? Pull request rejected.

Flur has nothing to be ashamed of, so why not add a link with a badge? (- it sounds a bit like spam;)) Such marketing - see how well-written project - has measures :)

Are you able to recommend something similar that will not be sonarqube, but will have similar functionality?

asienicki avatar Apr 03 '19 21:04 asienicki

I'll reopen this for consideration. I'm not ready to add a badge just yet, I'd first like to take some time to get to know the tool, understand the results, and decide what, if anything, is worth fixing. As far as other similar tools, this is an area I'm not very familiar with.

@kroniak Any opinions?

Thanks.

tmenier avatar Apr 05 '19 14:04 tmenier

@tmenier I can connect Flurl to my sonarcube account and will do this work in pipeline. Sonar increases code quality. I vote YES.

kroniak avatar Jul 29 '19 09:07 kroniak

@kroniak That works for me. Thanks

tmenier avatar Jul 29 '19 14:07 tmenier