Thayne McCombs

Results 593 comments of Thayne McCombs

I like the proposal in https://github.com/rust-lang/rfcs/pull/3796#issuecomment-2775430532, but the `feature = "abc"` syntax still needs to be supported for backwords compatibility, so we need to define how that interacts with the...

See also https://github.com/rust-lang/regex/pull/1228

Oh, yeah, it does look like __fish_complete_subcommand uses `string escape` now. That was only merged last week though, which is why I didn't see it when using 3.7.

I think this should be fixed in v0.6.5

Could there at least be an option to `custom_target` to tell it whether it should replace backslashes with forward slashes or not? I have a meson configuration where I use...

> then doesn't that mean we might try to succeed it it later in releaseN when it's already been succeeded? If it has already been succeeded, that means it has...

> Hmm I think I see your point. In releaseN we pop it from the queue when we succeed it, so it shouldn't be in the queue afterwards 🤔 Is...

Right so in that case, the finalizer would be run, but the promise would not be successfully fulfilled. It would either be done , in an interrupted state, or not...

I don't think removing the items from the queue during `restore` is strictly necessary. However, if we didn't do that, then we would instead need to check if the promise...