langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

Published 20 hours ago • verified publisher icon tmc

openaillm: remove internal client, use go-openai client instead

Open bdqfork opened this issue 1 year ago • 14 comments

For issue #119 , use go-openai client instead, which simplified a lot of code.

PR Checklist

  • [x] Read the Contributing documentation.
  • [x] Read the Code of conduct documentation.
  • [x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [x] Describes the source of new concepts.
  • [x] References existing implementations as appropriate.
  • [x] Contains test coverage for new functions.
  • [x] Passes all golangci-lint checks.

bdqfork avatar Jun 25 '23 15:06 bdqfork

@tmc Can this PR be merged? There may be more code conflicts in the future if we wait too long.

bdqfork avatar Jul 03 '23 10:07 bdqfork

This pull request was submitted a long time ago and has not been reviewed, so there may be some conflicts. It seems that it is difficult to fix them now.

bdqfork avatar Jul 18 '23 13:07 bdqfork

This pull request was submitted a long time ago and has not been reviewed, so there may be some conflicts. It seems that it is difficult to fix them now.

Any plans on resolving the conflicts or this pr is dead? I'd love to see github.com/sashabaranov/go-openai usage

KabudoWiseMan avatar Jul 24 '23 12:07 KabudoWiseMan

Hey sorry all, I let this get stale. I'm a little concerned about taking on the dependency but I'm supportive. can someone take a crack at a rebase?

tmc avatar Aug 26 '23 02:08 tmc

I will try later.

bdqfork avatar Sep 09 '23 11:09 bdqfork

@bdqfork anything I can do to help here, feel free to reach out on discord or otherwise. Would love to see this go in.

tmc avatar Sep 12 '23 20:09 tmc

@tmc @bdqfork would use this if merged given "tools" is the new way #507

jackspirou avatar Jan 30 '24 19:01 jackspirou

Is this effort no longer being prioritized?

pvora27 avatar Mar 11 '24 18:03 pvora27

I didn't choose to close the PR, it needed to be rebased, I'm still open to this if someone would like to contribute it.

tmc avatar Mar 19 '24 23:03 tmc

@bdqfork Can you make a revision on the latest main branch? Go-openai is indeed a comprehensive support library for openai. A new idea might be to create an openai v2 package, so there would be no conflicts to resolve. If the functionality is rich enough, then the previous openai package can be marked as deprecated.

any thoughts here?

douglarek avatar Jun 24 '24 06:06 douglarek

I remain open to this contribution and I welcome a fresh PR.

tmc avatar Jun 24 '24 07:06 tmc

Can we get a review of the discussion around the official azure sdk for this which might be worth considering on an "officially supported" capacity instead?

PylotLight avatar Jun 24 '24 13:06 PylotLight

The official player is here: https://github.com/openai/openai-go .

douglarek avatar Sep 04 '24 13:09 douglarek

I may want to give it a try using https://github.com/openai/openai-go if I have some success with my other PRs

treywelsh avatar Sep 24 '24 15:09 treywelsh