langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

add FilePart implement for ContentPart to support chat with file

Open geekr-dev opened this issue 1 year ago • 2 comments

… Gemini

PR Checklist

  • [x] Read the Contributing documentation.
  • [x] Read the Code of conduct documentation.
  • [x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [x] Describes the source of new concepts.
  • [x] References existing implementations as appropriate.
  • [x] Contains test coverage for new functions.
  • [x] Passes all golangci-lint checks.

geekr-dev avatar Oct 23 '24 11:10 geekr-dev

sorry, the func (FileContent) IsPart() {} method should be isPart with the first letter lowercase, and I hope you can change the method isPart in ContentPart interface to be public, then we can implement our own XXXPart in our logic code

geekr-dev avatar Oct 23 '24 11:10 geekr-dev

Nice PR! Lets make changes and approve it

ImPedro29 avatar Nov 20 '24 22:11 ImPedro29