grpc-websocket-proxy Propose upstream integration.

Propose upstream integration.

Open tmc opened this issue 7 years ago • 6 comments

I'd like to get this merged into the gateway as it's very closely related to it.

Dec 14 '17 17:12 tmc

Any update on this?

Mar 20 '20 11:03 TvdBrink

@TvdBrink I'm sure we could get it in -- I think some test coverage would be in order. Do you think you could assist with that?.

Mar 20 '20 17:03 tmc

@tmc yes of course. Any preference on using third party packages in tests?

Also, is there any chance we could incorporate the ping and pong handlers of gorilla web socket as in the chat example?

Mar 20 '20 18:03 TvdBrink

That sounds like a good example to express. My preference is to just use stdlib for testing (but maybe go-cmp for the comparison helper).

Mar 20 '20 18:03 tmc

Alright, I will make two PR's soon.

Mar 20 '20 19:03 TvdBrink

@tmc @TvdBrink

Hi, it seems that upstream integration is a no-win situation as of now?

May I ask why grpc_gateway is unwilling to merge this?

Thanks in advance.

Nov 26 '23 19:11 tamama