questionary icon indicating copy to clipboard operation
questionary copied to clipboard

Update prompt_toolkit to be compatible with ipython

Open FantasqueX opened this issue 1 year ago • 4 comments

Question

Hi, thanks for this wonderful library. My issue when using questionary is that the latest questionary requires prompt_toolkit<=3.0.36 https://github.com/tmbo/questionary/blob/master/pyproject.toml#L36 while another popular tool ipython requires prompt_toolkit>=3.0.41 https://github.com/ipython/ipython/blob/main/setup.cfg#L38. Because of pip's terrible dependency management, I cannot make questionary and ipython be both happy.

I saw you referred to an issue https://github.com/prompt-toolkit/python-prompt-toolkit/issues/1726, however it's not convenient to reproduce with a not well-maintained library(jellex). I wonder whether you can check 3.0.42 prompt_toolkit is compatible with questionary or provide a small reproducible code with questionary. Thank you.

What have you already tried?

Took a look at https://github.com/prompt-toolkit/python-prompt-toolkit/issues/1726

Read the documentation

  • [X] I have checked to ensure that my question is not answered by the documentation.

FantasqueX avatar Dec 19 '23 07:12 FantasqueX

I also ran into this with ipython.

Because of pip's terrible dependency management, I cannot make questionary and ipython be both happy.

What terrible dependency management? There are two packages with conflicting requirements, what is pip (or any other dependency manager) supposed to do other than error out mentioning the conflict?

gsakkis avatar Dec 27 '23 17:12 gsakkis

I've marked this as an enhancement. Happy to review any PRs for this.

kiancross avatar Dec 29 '23 02:12 kiancross

Also faced this issue. Would be very much appreciated :)

florian6973 avatar Mar 03 '24 13:03 florian6973

I'm facing this issue as well

Em1lyK avatar Mar 06 '24 09:03 Em1lyK

PLEASE merge FantasqueX fork into the official repository, the dependency issue is fixed by substituting the official package with the fork.

tosilswc avatar May 28 '24 09:05 tosilswc

This might be related https://github.com/prompt-toolkit/python-prompt-toolkit/issues/1809

danieltomasz avatar Jun 05 '24 09:06 danieltomasz

Can you make a bugfix release? v2.0.1 can't be packaged in distro repos as-is because of this problem.

If not, packaging v2.0.1 with https://github.com/tmbo/questionary/commit/9bb5ae1d740ec8d6b3caf3d81a9f71dc13bdd135 patch applied will do the thing.

CyberTailor avatar Aug 26 '24 05:08 CyberTailor