Tristan Matthews

@tterribe suggested as a preliminary step, simply varying the weights depending on quantizer. It may be worth it to dump whatever libaom's using as parameters for different QP.

via @KyleSiefring: https://aomedia.googlesource.com/aom/+/805c7d26fca822b33e22ee489b6de7ad287b6086

From running this script on subset1 ```sh tmatth@hydra ~ $ cat hack_metrics.sh #!/bin/sh set -e set -u SEQ=${1:-/mnt/raid/Videos/subset1-y4m/Air_Force_Academy_Chapel,_Colorado_Springs,_CO_04090u_original.y4m} BASENAME_SEQ=$(basename ${SEQ}) AOMDIR=aom-master/aom_build OUTDIR=~/out mkdir -p ~/out cd ${AOMDIR} for x in...

@tterribe suggests making cdef parameters depend on quantizer in terms of `log_target_q` instead of `ac_q(fi.base_q_idx, 0, bd) as i32;)`, e.g.: ``` let quantizer = bexp64(log_target_q + scale); rate.rs: let quantizer_u...

@tterribe suggests that for inter frames, we may want to search (as master is doing) but between 2 choices: strength dependent on qp vs. disabling CDEF entirely. I also want...

> I also want to compare only forcing strength based on QP for keyframes (and leaving inter frames with the existing search) to see if inter frames are where objective...

So commit 5625ee37c0d95f1887c20ff2e492e89653a6072d is pretty restrictive in terms of CDEF search (effectively disabling it), I think the next step would be to put the CDEF from QP mode behind a...

Basically this is at implementing this TODO: https://github.com/xiph/rav1e/blob/dc8bb6332f491191f988cf0f46468927c0bb896a/src/encoder.rs#L946

@xiphmont I know this is going back a ways, but do you recall why these strengths are multiplied by 4? https://github.com/xiph/rav1e/blob/e9be6c95ec6b1b9fced8a5ab514709778c771c43/src/encoder.rs#L698

We could just dump this sort of thing in a wiki or somewhere more appropriate for "moving target" type info.