ivona-node icon indicating copy to clipboard operation
ivona-node copied to clipboard

Published 20 hours ago • verified publisher icon tmanderson

This code needs tests around its functionality

Open stsvilik opened this issue 9 years ago • 4 comments

If you intend to make it popular and growing you will need to put together tests around its functionality. You could start with mocha + istanbul for code coverage.

stsvilik avatar Jan 19 '16 15:01 stsvilik

I definitely agree with you there. I'll have to dig into the proxy module a bit more (and potentially update this), as it was a contributed from @kuzzmi.

tmanderson avatar Jan 20 '16 14:01 tmanderson

@tmanderson, I'm still here, so if any help is needed, just let me know. Probably the proxy module will require some more testable structure, so I'll take a look at it once again.

kuzzmi avatar Jan 20 '16 15:01 kuzzmi

@kuzzmi that would be awesome if you could get started on that! I can follow suit on the main module for the bits that are there.

Thanks!

tmanderson avatar Jan 20 '16 17:01 tmanderson

The proxy error I was getting is “SSL23_GET_SERVER_HELLO:unknown protocol” which was mainly caused by proxy not being able to communicate over https.

stsvilik avatar Jan 20 '16 23:01 stsvilik