helm-bibtex
helm-bibtex copied to clipboard
add a separate follow processor for helm
Thanks for your great package!
Having helm-bibtex open as the follow processor is not ideal, since to take an action, we need to press tab and then not all actions are meaningful when point is on a citation. The PR adds a separate follow processor and two new variables, helm-bibtex-follow-actions-alist
and helm-bibtex-follow-full-frame
, to customize it. To use this processor, this should be added to the init file:
(org-cite-register-processor 'my-bibtex-org-cite-follow
:follow 'helm-bibtex-follow)
(setq org-cite-follow-processor 'my-bibtex-org-cite-follow)
Hi and thank you. I can't test this right now. Could you please explain in one sentence what this follow processor does differently? And woudn't it be better to just replace the existing processor?
Sure, but it's more than 1 sentence :)
In current setup:
- After following a citation, the entry is only pre-selected, and user needs to select it again to take any action.
- Not all actions are applicable for citations (I wouldn't want to insert the whole bibtex entry into a citation)
- I prefer to have helm-bibtex take the whole buffer, but selecting from a few follow actions doesn't need the whole buffer.
This PR solves 1 and adds better defaults and customization options for 2 and 3.
And woudn't it be better to just replace the existing processor?
I'm not sure what you mean. This is exactly what this PR does!
Actually it might be good to add
(org-cite-register-processor 'helm-bibtex-org-cite-follow
:follow 'helm-bibtex-follow)
to the commit and then the user has the option of using this follow processor by adding
(setq org-cite-follow-processor 'helm-bibtex-org-cite-follow)
to their init file.
Looks good. Could you please also update the documentation here to reflect these changes? Thank you!
Sure! I just made some changes. Let me know if there's anything else here I can change.
merged, thank you!