asn-qr-code-label-generator icon indicating copy to clipboard operation
asn-qr-code-label-generator copied to clipboard

Published 20 hours ago • verified publisher icon tmaier

Generate QR codes locally

Open leimer opened this issue 9 months ago • 3 comments

Thanks for your highly appreciated work on the label template. I like it a lot :-) Thank you very much!

I came to notice the script is using an online service to render QR codes. I'd like to suggest to use a simple and stable javascript library to generate the QR codes locally without any additional network traffic. This website - once stored locally - can then be used at offline locations.

leimer avatar May 07 '24 12:05 leimer

Just realized: the codes get only rendered once. Feels like the x-init attribute is executed only once. I will update my PR. Please stay tuned ;-)

leimer avatar May 10 '24 00:05 leimer

Hi, thanks for your contribution.

You are using a very dated library. One which has not been updated for 9 years. Please consider replacing it with a more popular solution.

tmaier avatar May 26 '24 08:05 tmaier

You are using a very dated library. One which has not been updated for 9 years. Please consider replacing it with a more popular solution.

I tried switching to qrcode, but it loads dependencies by require, which is unavailable inside the browser. I found less popular but newer QRious library, which works even smoother. Feels like the qrcode libraries are pretty stable.

Since this is a very simple tool, with only local execution, I don't have the normal paranoia regarding updated libs.

leimer avatar May 26 '24 22:05 leimer