toby lorne

icon indicating a website link https://www.toby.codes icon indicating an email [email protected]

icon company booking.com icon location rotterdam, nl icon location alum @alphagov @cabinetoffice @UKForeignOffice McGill U. currently @bookingcom. as211208; talk to me about ipv6

Results 12 comments of toby lorne

apimachinery's unstructured converter panics if the destination struct contains private fields

As above, the controller-runtime is using this reflection fork in apimachinery inside the `CreateOrUpdate` function https://github.com/kubernetes-sigs/controller-runtime/blob/e6c3d139d2b6c286b1dbba6b6a95919159cfe655/pkg/controller/controllerutil/controllerutil.go#L312 It is using this reflection fork because of historical false positives https://github.com/kubernetes-sigs/controller-runtime/issues/464 `reflect.DeepEqual` considers...

apimachinery's unstructured converter panics if the destination struct contains private fields

Your point is valid 👍 I have raised https://github.com/kubernetes/kubernetes/pull/126998 which gives a method DeepEqualWithOptions with an option to ignore unexported fields. If this gets merged I can then use this...