eslint-plugin-jasmine icon indicating copy to clipboard operation
eslint-plugin-jasmine copied to clipboard

feat: new rule capitalized-it

Open rabidkitten opened this issue 6 years ago • 2 comments

Added a new rule, capitalized-it, that enforces whether an it statement starts with a capital or lowercase first letter. For example: in the statement 'it("First word...", ...)', "First" can be enforced as starting with a capital or a lower case letter.

rabidkitten avatar May 11 '18 17:05 rabidkitten

This rule looks great to me, I'd love to have it in this repo. Curious if you (the author) or the repo maintainer have any specific reasons not to move forward with it?

I'd suggest squashing your PR to a single cleaned up commit, and potentially changing the rule name to match eslint's naming scheme -- I'd suggest prefer-capitalized-spec ("spec" is more generic than "it", which could also be iit/fit/xit etc; eslint rules tend to favor either no- to indicate they ban a bad behavior, or prefer- to indicate they enforce a stylistic choice).

elliot-nelson avatar Apr 18 '19 09:04 elliot-nelson

@elliot-nelson , thanks for digging this up, we just probably overlooked the PR. And I agree, looks like it almost good to go, and agree with your comment on the rule name. Also @rabidkitten please make sure commits messages follow angular convention.

DianaSuvorova avatar Apr 19 '19 22:04 DianaSuvorova