enjoi icon indicating copy to clipboard operation
enjoi copied to clipboard

Update needed to support new version of Hapi and Joi

Open rmothilal opened this issue 5 years ago • 7 comments

Hapi and Joi have had a massive refactor of their libraries https://github.com/hapijs/joi/issues/2037 hapi-openapi relies on this library to validate a swagger. The enjoi library needs an update to use these latest libraries so that hapi-openapi can use the latest version of this

rmothilal avatar Oct 10 '19 11:10 rmothilal

@tlivings has there been any progress here? I have been doing a code upgrade on my fork https://github.com/rmothilal/enjoi/tree/feature/make-enjoi-compatible-with-joi-16 I am having issues with the allOf extension as well as the tests for override extensions. Any assistance would be greatly appreciated @JoeScho @tlivings

rmothilal avatar Feb 26 '20 17:02 rmothilal

Want to submit a PR? I can pull it down and experiment.

tlivings avatar Feb 26 '20 19:02 tlivings

Hi @tlivings, thanks for the reply, I have created a PR https://github.com/tlivings/enjoi/pull/85 Please let me know what changes you require

rmothilal avatar Feb 27 '20 09:02 rmothilal

Hey - poor timing on my behalf 😆 I also created a PR which I think fixes this #84. Please feel free to close it if you decide to merge #85

JoeScho avatar Mar 03 '20 09:03 JoeScho

@tlivings Have you managed to review anything in my PR?

rmothilal avatar Mar 09 '20 14:03 rmothilal

@rmothilal I am reviewing it. Thanks.

tlivings avatar Mar 10 '20 17:03 tlivings

Is this fixed with new version 7.0.0?

svrnwnsch avatar May 26 '20 13:05 svrnwnsch