Thomas Hunter II comments

Results 216 comments of


                                            Thomas Hunter II

Hook not altering resource name to include path

Looks like this issue is pretty old and the OP didn't reply to Roch's question. Is it still an issue? It looks like things were solved so I'll close it...

Cache external git call results

@juan-fernandez are you tracking this change request somewhere else? And if so is it okay if I close this PR?

Split plugins into their own packages

FYI, we did land official esbuild support. Please try the new plugin and see if it helps: https://docs.datadoghq.com/tracing/trace_collection/automatic_instrumentation/dd_libraries/nodejs/#esbuild-support If the graphql stuff is still an issue you can add this...

Mock dd-trace implementation to be used for testing dd-trace integration?

It looks like Bryan was able to provide a solution to this issue so I'll close it for now. Feel free to reopen if it's still relevant!

fix coverage for datadog-instrumentations

@bengl is this PR safe to close? The relevant line in package.json now looks like this so I think the intent of this PR is already in master: ``` "test:plugins:ci":...

fix coverage for datadog-instrumentations

I'll close this PR for now but we can consider reopening it in the future.

Yarn Plug'n'Play Support

This is a pretty old issue and it looks like @drphelps came up with a workaround. I'll close it for now but if it's still relevant feel free to reopen.

Fix aws-sdk distributed tracing when using .promise()

Is this a feature that you'd still be interested in working on? Looks like there are some conflicts and that Roch had some concerns.

Fix aws-sdk distributed tracing when using .promise()

I'll close this PR for now but we can consider reopening it in the future.

Can't compile with Nuxt / Node 16.x and dd-trace 2.x

It looks like this issue was wrapped up. If I'm misunderstanding feel free to reopen and tag us.