react-native-audio-streaming icon indicating copy to clipboard operation
react-native-audio-streaming copied to clipboard

Undefined is not an object(evaluating react3.default.proptypes.string), does not work with latest [email protected]

Open yogendrakarekar opened this issue 7 years ago • 11 comments

The library is not updated to suit with latest [email protected]

yogendrakarekar avatar Oct 06 '17 08:10 yogendrakarekar

@yogendrakarekar if you install from 2a4a95784426e55cc16e7acfd38c683b7d87f233 (this is the tip of master as of this comment), it'll work.

@tlenclos do you plan on releasing a version bump to publish the fix in npm?

nickdirienzo avatar Oct 27 '17 08:10 nickdirienzo

Hi,

Well, are you asking me whether I wish make corrections and release a new version of this plugin to suit up with react [email protected], well I don't have any such plans.

But would love to help you out, take up a task, that you suggest, and do it.

Thanks & Regards Yogendra U. Karekar Mobile:-9769856284 Email:[email protected]

On Fri, Oct 27, 2017 at 1:50 PM, Nick DiRienzo [email protected] wrote:

@yogendrakarekar https://github.com/yogendrakarekar if you install from 2a4a957 https://github.com/tlenclos/react-native-audio-streaming/commit/2a4a95784426e55cc16e7acfd38c683b7d87f233, it'll work.

@tlenclos https://github.com/tlenclos do you plan on releasing a version bump to publish the fix in npm?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/118#issuecomment-339905908, or mute the thread https://github.com/notifications/unsubscribe-auth/AMhrFZvAC7G7qwayq77aXGrcuMEd46VEks5swZJIgaJpZM4PwJZk .

yogendrakarekar avatar Oct 28 '17 08:10 yogendrakarekar

@yogendrakarekar no I wasn't suggesting that. There's a fix already in master, so you can have your react-native-audio-streaming dependency point to the SHA (or #master). Then it should work for you.

I was wondering if the maintainer had plans to publish a new version on npm which includes that fix since it's been in the repository for a while now.

nickdirienzo avatar Oct 28 '17 18:10 nickdirienzo

Please bump the npm version

dzmitrys-dev avatar Nov 06 '17 15:11 dzmitrys-dev

@nickdirienzo what's the right way to point it master. I am currently just doing npm i -S https://github.com/tlenclos/react-native-audio-streaming#master. Is there another way to do it?

theeomm avatar Nov 14 '17 09:11 theeomm

@TheeOMM in your package.json, try "react-native-audio-streaming": "git+https://github.com/tlenclos/react-native-audio-streaming.git"

BuffMcBigHuge avatar Nov 17 '17 01:11 BuffMcBigHuge

@TheeOMM yes, what @BuffMcBigHuge said but replace react-native-autogrow-textinput with react-native-audio-streaming. Or you can do npm install tlenclos/react-native-audio-streaming. Hope this helps!

nickdirienzo avatar Nov 17 '17 15:11 nickdirienzo

@nickdirienzo Ah! Thanks for pointing that out! I was upgrading React to 0.49.5 and the autogrow package had the same issue!

BuffMcBigHuge avatar Nov 17 '17 16:11 BuffMcBigHuge

Please ... am confuse how to install from #master. Can someone do step by step instruction. Thanks for your time.

salisuabubakar avatar Nov 19 '17 11:11 salisuabubakar

Finally i was able to install but app crashes before launch. I think there is an issue using it with Wix React Native Navigation. Can someone help. Thanks

salisuabubakar avatar Nov 20 '17 09:11 salisuabubakar

import PropTypes from 'prop-types'; Player.propTypes = { url: PropTypes.string.isRequired };

Erenner avatar Dec 05 '19 10:12 Erenner