signia icon indicating copy to clipboard operation
signia copied to clipboard

Vite's Hot module replacement doesn't work with signia-react-jsx

Open Lippiece opened this issue 2 years ago • 2 comments

Thank you for your work.

I've added jsxImportSource to tsconfig and vite config and observe that despite Vite reporting reacting to changes, they are not reflected in browser until manually refreshed.

May be related to https://github.com/preactjs/signals/issues/250

Lippiece avatar Mar 17 '23 12:03 Lippiece

thanks for the report! :heart:

Just had a quick look into this, not 100% clear what's going on. It seems that by wrapping the components we're breaking some assumptions that the React fast refresh code makes. I'll ask in the vite plugin repo whether they have any tips.

ds300 avatar Mar 17 '23 13:03 ds300

Is there any other issue that might track about this?

arpadgabor avatar Apr 05 '23 20:04 arpadgabor