tldr-node-client icon indicating copy to clipboard operation
tldr-node-client copied to clipboard
verified publisher icon tldr-pages

add support for node v16

Open navarroaxel opened this issue 4 years ago • 7 comments

Description

Please explain the changes you made here.

Checklist

Please review this checklist before submitting a pull request.

  • [ ] Code compiles correctly
  • [ ] Created tests, if possible
  • [x] All tests passing (npm run test:all)
  • [ ] Extended the README / documentation, if necessary

navarroaxel avatar May 19 '21 12:05 navarroaxel

Why drop 10?

bl-ue avatar May 19 '21 14:05 bl-ue

I'm not eager on dropping v10 support either but I guess it can be safely done since it reached the EOL stage just recently: https://github.com/nodejs/Release/tree/14e3d74#end-of-life-releases

vladimyr avatar May 19 '21 15:05 vladimyr

Should we also update the min engine version here: https://github.com/tldr-pages/tldr-node-client/blob/3511d91454e1056d4c0926216a15044295734f0c/package.json#L25 to be above 10?

agnivade avatar May 19 '21 15:05 agnivade

It should reflect tested versions, so >=12 seems more appropriate.

vladimyr avatar May 19 '21 15:05 vladimyr

Ha! It went into Maintenance LTS Start on 2020-05-19, one year ago today! 😮

bl-ue avatar May 19 '21 16:05 bl-ue

@vladimyr - Do you feel this needs a major version from the tool's perspective? Or it's okay to bump the minor version?

agnivade avatar May 19 '21 18:05 agnivade

@agnivade Take a look at this example https://github.com/sindresorhus/open-cli/releases Bump from v5 to v6 was exactly due to a change in minimum supported node version so my answer is: yes we need a major version bump.

vladimyr avatar May 21 '21 00:05 vladimyr