tlaplus
BUG: quoting of environment variables for CI, and automatically run `release.yml`
-
BUG: correct quoting of environment-variable values in the script
setup_shell_env.py, to avoid errors in CI workflow ofrelease.yml. -
run workflow of file
.github/workflows/release.ymlwhenever the file changes, and also twice a year. -
add underscores and "UTC" to tag name created by GitHub Actions when running
release.yml.
@johnyf could you rebase these on the current CI files to see whether these changes should be merged?
Rebased the changes onto branch main. The changes are:
- release tag name of the form
YEAR_MM_DD_UTC_HH_MM - running
release.ymlwhen it changes, and twice a year - showing contents of
*.errand*.outfiles when tests fail, inci.yml.
Thanks for doing the rebase!
- Was the original fix for quoting environment variables no longer necessary?
- I like the practice of dumping test output files to console so we get the output in the CI!
- I am not sure about the updated release practice; may have to defer to someone else in their thoughts here.
P.S. there's a requirement to sign your commits with a DCO (basically just saying you personally wrote this code and can legally contribute it and it isn't copied from a proprietary codebase or whatever), the github CI failure should have a link telling you how to retroactively add a DCO signoff to your commits.
Yes, the original fix for quoting environment variables was to code that is not in the current main branch.
The automated building with cron could be omitted.
Added the DCO signoff to the commits. Thank you for reviewing the changes.
In #92 there was discussion of moving to a rolling release model (which I have really been dragging my feet on getting around to doing). So I think people want to keep the current release model then transition to that one, instead of releasing every six months + whenever release.yml is modified. However, I like all the other changes!
Also @damiendoligez as FYI, I believe this is the issue you mentioned in the last community meeting