Talley Lambert
Talley Lambert
the failing benchmarks are these: ``` | Change | Before [8bf2d823] | After [c8af7ac1] | Ratio | Benchmark (Parameter) | |----------|----------------------------|---------------------|---------|-----------------------------------------------| | + | 1.77±0.01μs | 2.90±0.01μs | 1.64 |...
ok, to summarize some stuff here: 1. indeed, it is not possible to subclass SignalInstance in the compiled version (sorry that I forgot that when advising you to try that...
yeah, that would be one option to look into for the second option of "evaluating usage patterns in imswitch". might be easiest to do that over zoom with @beniroquai
with a proxy object like that, I generally just lie to the type checker: ```python if TYPE_CHECKING: from psygnal import Signal else: class Signal: ... ```
Hey @hanjinliu, would you mind taking a look at this? I think it's an issue in the ListWidget [here](https://github.com/pyapp-kit/magicgui/blob/e18ddc6883249fad5dc1cbfc8e3c00152ab91371/src/magicgui/widgets/_concrete.py#L750-L753), and you know that widget better than I do
if you think it's specific to guiclass (and how it interacts with the list widget), could it be related to the signature of the callback that is connected to a...
tests are failing during building of mypyc, due to https://github.com/pydantic/pydantic/issues/10907
Thanks @multimeric, yeah indeed, python doesn't support intersection types (https://github.com/python/typing/issues/213) which is what we'd really need here. We do actually already have the class-based approach you are describing [here](https://github.com/pyapp-kit/magicgui/blob/e18ddc6883249fad5dc1cbfc8e3c00152ab91371/src/magicgui/schema/_guiclass.py#L324-L348), it's...
ah actually, I forgot I did most of the work in making GuiBuilder public and agnostic to the name "events" in https://github.com/pyapp-kit/magicgui/pull/688/ will try to get that merged soon and...
Hey @SJShep, Yes this is probably related to https://github.com/pymmcore-plus/pymmcore-plus/pull/481 which in turn was made to support the upstream changes in the c++ code: https://github.com/micro-manager/mmCoreAndDevices/pull/659 long story short: - the C++...