Talley Lambert
Talley Lambert
I'm out of the country for another few days, sorry for the delay
all set for merge?
i can certainly see the usefulness of accepting svg paths. We just need to be careful not to overload the interpretation of the string too much, so if the icon...
ah, you're getting to the concepts of themes then. which is not something that app-model currently tracks. I would expect that to go in [napari's `Theme.icon`](https://github.com/napari/napari/blob/bed967f81fcef2b86bd83d5c1b741d98cc2d91fe/napari/utils/theme.py#L81). The icon color in...
i think this should be an app-specific preference at best. using `+` is very common, and appeared to be the more common delimiter when I looked around when first implementing...
source should be immutable. we definitely want to know who contributed a keybinding at registration time and I don't see any need for that to be mutable. i can see...
> in what case would we be interested in registering several commands to the same key sequence from the same source, e.g., user? what if multiple plugins register the same...
> Sounds good. And would you want to let the user amend these source names? lets start with no, add later if needed > Kira sorted keybindings in the registry...
yep, a reverse index is definitely going to be useful here. Actually, I'm remembering now that `get_keybinding` is not intended for runtime lookup upon keypress. it's just a way to...